-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cypress questions.cy.js with PyTest integration tests. #401
Comments
I'd like take on this task. Is there any deadline? |
Hi @tadakongithub! Thank you for your interest, I really appreciate this 👍 |
Ok. I'll try my best to make progress as quickly as possible. I'm learning Cypress and Pytest, so it might take a little time. |
Hi. I'm a bit new to making tests and python app in general. While I'm writing in vs code, it says import "pytest" could not be resolved. Same goes for flask. Can you advise what I'm doing wrong? |
@tadakongithub to make able to run the project and pytest you need to setup your docker environment first. Please make sure you follow the guide Then you should be able to run any command in your docker container and connect to running containers from your IDE |
Thanks! I was able to run pytest locally. Also formatted the code with black. I should be able to make a PR soon. |
Just made a PR. Let me know if I need to make any changes |
Thank you! I really appreciate this 👍 |
I used to be able to create a pull request from a working branch of my forked repo to the develop branch of the upstream repo. Now I can't seem to do that. Did something change? Should I push directly to the develop branch of the upstream repo? |
@tadakongithub it's probably due to the fact that you already have the PR and all new changes go there. |
@tadakongithub You should be able to create multiple pull requests from your fork, but they have to be on unique branches with different names. Is that what you're running into? |
test was written for questions in pytest to solve the issue #401
We can close this now that #477 is merged. Thanks! |
Now that it's merged, the pull request screen looks how it originally looked and it seems I can make a new PR now. I wonder if I cannot make multiple PR from my fork. Or maybe it was simply because my added commits went to the same PR I made. Thanks for reviewing! |
You should definitely be able to open multiple PRs from your fork. I've done that a few times for this project. They just have to be from separate branches. |
No description provided.
The text was updated successfully, but these errors were encountered: