Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cypress questions.cy.js with PyTest integration tests. #401

Closed
danmash opened this issue Oct 12, 2022 · 14 comments
Closed

Replace cypress questions.cy.js with PyTest integration tests. #401

danmash opened this issue Oct 12, 2022 · 14 comments

Comments

@danmash
Copy link
Member

danmash commented Oct 12, 2022

No description provided.

@tadakongithub
Copy link
Contributor

I'd like take on this task. Is there any deadline?

@danmash
Copy link
Member Author

danmash commented Nov 26, 2022

Hi @tadakongithub! Thank you for your interest, I really appreciate this 👍
There's no deadline. I'll send a follow-up in the comments in some time if no progress.
Feel free to ask any questions here or via chat https://t.me/climatemind_chat

@tadakongithub
Copy link
Contributor

tadakongithub commented Nov 26, 2022

Ok. I'll try my best to make progress as quickly as possible. I'm learning Cypress and Pytest, so it might take a little time.

@tadakongithub
Copy link
Contributor

tadakongithub commented Dec 5, 2022

Hi. I'm a bit new to making tests and python app in general. While I'm writing in vs code, it says import "pytest" could not be resolved. Same goes for flask. Can you advise what I'm doing wrong?

@danmash
Copy link
Member Author

danmash commented Dec 5, 2022

@tadakongithub to make able to run the project and pytest you need to setup your docker environment first. Please make sure you follow the guide
Let me know if you have any problems with the installation.

Then you should be able to run any command in your docker container and connect to running containers from your IDE

@danmash danmash moved this from To do to 🏗 In progress in Climate Mind Web App Dec 5, 2022
@tadakongithub
Copy link
Contributor

Thanks! I was able to run pytest locally. Also formatted the code with black. I should be able to make a PR soon.

@tadakongithub
Copy link
Contributor

Just made a PR. Let me know if I need to make any changes

@danmash
Copy link
Member Author

danmash commented Dec 11, 2022

Thank you! I really appreciate this 👍

@tadakongithub
Copy link
Contributor

I used to be able to create a pull request from a working branch of my forked repo to the develop branch of the upstream repo. Now I can't seem to do that. Did something change? Should I push directly to the develop branch of the upstream repo?

@danmash
Copy link
Member Author

danmash commented Dec 17, 2022

@tadakongithub it's probably due to the fact that you already have the PR and all new changes go there.
@brianpeiris can you please advise on this?

@brianpeiris
Copy link
Member

@tadakongithub You should be able to create multiple pull requests from your fork, but they have to be on unique branches with different names. Is that what you're running into?
I don't have full access to the repo settings here, but I assume nothing changed there. I'm still able to create PRs from my fork.

brianpeiris added a commit that referenced this issue Dec 17, 2022
test was written for questions in pytest to solve the issue #401
@brianpeiris
Copy link
Member

We can close this now that #477 is merged. Thanks!

Repository owner moved this from 🏗 In progress to ✅ Done in Climate Mind Web App Dec 17, 2022
@tadakongithub
Copy link
Contributor

Now that it's merged, the pull request screen looks how it originally looked and it seems I can make a new PR now. I wonder if I cannot make multiple PR from my fork. Or maybe it was simply because my added commits went to the same PR I made.

Thanks for reviewing!

@brianpeiris
Copy link
Member

You should definitely be able to open multiple PRs from your fork. I've done that a few times for this project. They just have to be from separate branches.
Let us know if you run into that issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants