Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend minimum temperature tolerance from 150 K to 130 K #511

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

emileten
Copy link
Contributor

@emileten emileten commented Jan 18, 2022

This upgrades the container in qualitycontrol-cmip6 template to the recently released dodola 0.16.0 version, in order to use a wider temperature validation range with a lower bound at 130 K instead of 150 K, from this PR : ClimateImpactLab/dodola#170.

@emileten emileten self-assigned this Jan 18, 2022
@emileten emileten requested a review from brews January 18, 2022 23:05
@brews
Copy link
Member

brews commented Jan 18, 2022

Cool. Yeah, and this is what closes #510, where we found this error.

Copy link
Member

@brews brews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brews brews added bug and removed enhancement labels Jan 18, 2022
@brews
Copy link
Member

brews commented Jan 18, 2022

Actually, I'm not sure this is a bug or not. I maybe should not have changed that PR label. Either way, I think you're set to merge this whenever you're ready @emileten.

@emileten emileten merged commit 8e1432a into ClimateImpactLab:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants