Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError in dodola.cli.py::rechunk #63

Merged
merged 3 commits into from
Apr 21, 2021
Merged

Fix TypeError in dodola.cli.py::rechunk #63

merged 3 commits into from
Apr 21, 2021

Conversation

brews
Copy link
Member

@brews brews commented Apr 21, 2021

Get this when running the new dodola rechunk:

dc6-dev-djdj6-3755863106: Traceback (most recent call last):
dc6-dev-djdj6-3755863106:   File "/opt/conda/bin/dodola", line 33, in <module>
dc6-dev-djdj6-3755863106:     sys.exit(load_entry_point('dodola', 'console_scripts', 'dodola')())
dc6-dev-djdj6-3755863106:   File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 829, in __call__
dc6-dev-djdj6-3755863106:     return self.main(*args, **kwargs)
dc6-dev-djdj6-3755863106:   File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 782, in main
dc6-dev-djdj6-3755863106:     rv = self.invoke(ctx)
dc6-dev-djdj6-3755863106:   File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
dc6-dev-djdj6-3755863106:     return _process_result(sub_ctx.command.invoke(sub_ctx))
dc6-dev-djdj6-3755863106:   File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
dc6-dev-djdj6-3755863106:     return ctx.invoke(self.callback, **ctx.params)
dc6-dev-djdj6-3755863106:   File "/opt/conda/lib/python3.8/site-packages/click/core.py", line 610, in invoke
dc6-dev-djdj6-3755863106:     return callback(*args, **kwargs)
dc6-dev-djdj6-3755863106: TypeError: rechunk() missing 2 required positional arguments: 'variable' and 'maxmemory'

In PR #60, looks like we failed to properly connect/reconnect the CLI inputs and dodola.services.rechunk (again). Should consider testing for this if this becomes more and more common.

@brews brews added the bug Something isn't working label Apr 21, 2021
@brews brews added this to the v0.2.0 milestone Apr 21, 2021
@brews brews self-assigned this Apr 21, 2021
@brews brews requested a review from dgergel April 21, 2021 20:18
@brews
Copy link
Member Author

brews commented Apr 21, 2021

@dgergel I screwed up connecting the CLI with dodola.service.rechunk again. I'm hoping this will be a quick fix. Would you please review/double check this fix once you have a second?

@dgergel
Copy link
Member

dgergel commented Apr 21, 2021

@brews this fix looks good to me. I didn't check the rest of the code from #60 but I'm assuming you tested this already.

@brews
Copy link
Member Author

brews commented Apr 21, 2021

That's great! Thanks, @dgergel.

Merging.

@brews brews merged commit cfa90a4 into main Apr 21, 2021
@brews brews deleted the fix_rechunk branch April 21, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants