Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected DTR ceiling boolean expression and tests accordingly #166

Conversation

emileten
Copy link
Contributor

@emileten emileten commented Dec 29, 2021

This corrects a bug introduced by #165.

In the DTR ceiling we were making use of direct comparison operators like or etc... Which lead to a typical error with arrays.

This was not caught by the tests because there was only one latitude coordinate.

Changes :

  • switched to xr.ufuncs logical operators
  • enhanced tests by using arrays with with several latitude coordinates.

I am not doing anything to the changelog because this is just an extension of #165.

@emileten emileten requested review from brews and removed request for brews December 29, 2021 08:24
@emileten emileten self-assigned this Dec 29, 2021
@emileten emileten added the bug Something isn't working label Dec 29, 2021
@emileten emileten merged commit 6e9eb50 into ClimateImpactLab:main Dec 29, 2021
@brews
Copy link
Member

brews commented Dec 29, 2021

Wicked. Thanks @emileten. Appreciate you updating the test for this. That's the right move.

Your instinct about not adding a new CHANGELOG entry for this is correct, instead, just add this PR to the existing entry. I added this for you in 20e923e.

@emileten
Copy link
Contributor Author

Thanks for doing that @brews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants