update WDF correction with Hempel et al 2013 additions #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brews
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
@dgergel, I gave this a quick look and I only had one comment to clarify these changes and the evolving method in the changelog (see in-line comments).
Aside from that one suggested change I think you're good to merge this whenever you're ready. 👍
CHANGELOG.md
Outdated
| @@ -5,7 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [Unreleased] | |||
| - Update wet day frequency correction again to raise the "low" value used to the threshold value / 10 (PR #159, @dgergel) | |||
| - Update wet day frequency correction to incorporate method additions from Hempel et al 2013. (PR #162, @dgergel) | |||
| - Update wet day frequency correction again to raise the "low" value used to the threshold value / 10. (PR #159, @dgergel) | |||
There was a problem hiding this comment.
@dgergel To avoid confusion, you can combine these two entries into one (describing the recent implementation) and then reference both PR numbers in the () at the end of the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the WDF correction with additions from the ISI-MIP WDF correction method outlined in Hempel et al 2013 (https://esd.copernicus.org/articles/4/219/2013/esd-4-219-2013.html).
Three key changes are made:
These changes are made to address the ongoing challenges of applying a WDF correction at a global scale and having mismatched dry days in the reference and model output, resulting in some precip values being physically unrealistic.