Easy Button (easy-button-button dimension edits)

[rwithers]

My goal was to get the easy button to center a button icon within the boundaries of the button. That proved difficult and I felt it should be default behavior. I am very willing to discuss this at a later date or time, as I'm probably doing something wrong.

A more detailed explanation:

I Removed the width and height from the easy button button. At 100% a piece it was causing icons to float against the upper edge of the button. By removing the width and height from the easy-button-button class I was able to produce the desired behavior.

I would love to hear from you at your convenience. Thanks for considering this request.

[atstp]

I'll take a look at in the next day or so, but in the meantime, do you have any more info on how you were using it? Were you supplying the plain icon string, were you using EasyButtons's states, were you using any other css libs?

Adding the css for EasyButton came about kind of late in the more recent rewrite and it was mostly based off the core Leaflet css; it almost certainly could be improved upon. Thanks for the pr!

[rwithers]

Cliff,

Thanks for getting back to me. I will prepare something later today or
tomorrow that shows the use case. I'm still learning a lot so I'm not sure
how much additional help I'll be able to provide, but I am very willing.

I was using the easy button as part of a geo spatial Bootcamp we ran for a
client of ours. So you did get some pr in front of about 15 devs, and I
was glad to do it.

I'll be in touch,

Ryan

On Thursday, May 19, 2016, atstp notifications@github.com wrote:

I'll take a look at in the next day or so, but in the meantime, do you
have any more info on how you were using it? Were you supplying the plain
icon string, were you using EasyButtons's states, were you using any other
css libs?

Adding the css for EasyButton came about kind of late in the more recent
rewrite and it was mostly based off the core Leaflet css; it almost
certainly could be improved upon. Thanks for the pr!

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#42 (comment)

Ryan Withers
Senior Software Developer / Analyst

http://www.linkedin.com/in/ryanwithers
Work: (314) 799-5817

[rwithers]

Hi Cliff,

I have an example worked up now that shows the problem and my proposed
fix. The code on the master has the problem it can be pulled down from:

https://github.com/rwithers/leaflet-easy-button-example.git

I have checked-in the changes that I think represent an okay fix. You can
find the changes on a branch in the repository above. The branch is named
'fix-for-float-error', please let me know if you have any trouble
retrieving this. I believe the repo was made public so you should have
access to it. I am going to attempt to give you commit access now.

I'll look forward to hearing from you. Sorry it took so long.

Ryan

On Thu, May 19, 2016 at 2:04 AM, atstp notifications@github.com wrote:

I'll take a look at in the next day or so, but in the meantime, do you
have any more info on how you were using it? Were you supplying the plain
icon string, were you using EasyButtons's states, were you using any other
css libs?

Adding the css for EasyButton came about kind of late in the more recent
rewrite and it was mostly based off the core Leaflet css; it almost
certainly could be improved upon. Thanks for the pr!

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#42 (comment)

Ryan Withers
Senior Software Developer / Analyst

http://www.linkedin.com/in/ryanwithers
Work: (314) 799-5817

[atstp]

This looks great so far!

I'll take a proper look at it tomorrow morning and get back to you 👍

[atstp]

Sorry, this issue slipped through the cracks. It's back on my radar.

[rwithers]

That's okay it's nothing I need for a production deploy and we are running
a million miles an hour here.

Thanks,

Ryan

On Wednesday, June 29, 2016, atstp notifications@github.com wrote:

Sorry, this issue slipped through the cracks. It's back on my radar.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#42 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/APXLDY6eTgiv_rSxw7zoOSdfGApoxya_ks5qQsVJgaJpZM4Ih6SU
.

Ryan Withers
Senior Software Developer / Analyst

http://www.linkedin.com/in/ryanwithers
Work: (314) 799-5817