Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat unknown types as Strings in ODBCDriver2 format #276

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Treat unknown types as Strings in ODBCDriver2 format #276

merged 3 commits into from
Mar 10, 2020

Conversation

traceon
Copy link
Collaborator

@traceon traceon commented Mar 6, 2020 •
edited
Loading

...since they come as strings, they can be stored and served as strings.

Note, that this is not the case for RowBinaryWithNamesAndTypes format. When using it, unsupported types will cause hard failures.

@traceon traceon requested a review from Enmk March 9, 2020 10:18
Enmk
Enmk approved these changes Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be no tests on added feature/workaround, but Ok

@traceon traceon merged commit 7960bb3 into ClickHouse:master Mar 10, 2020
@traceon traceon deleted the odbcdriver2-unknown-types-as-strings branch March 10, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enmk Enmk Enmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traceon @Enmk