Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support [16]byte/[]byte typed scan/append for IPv6 column #996

Merged
merged 3 commits into from
May 17, 2023
Merged

Support [16]byte/[]byte typed scan/append for IPv6 column #996

merged 3 commits into from
May 17, 2023

Conversation

crisismaple
Copy link
Contributor

@crisismaple crisismaple commented May 12, 2023 •
edited
Loading

Summary

add support for [16]byte/[]byte IPv6 columns #976

Checklist

  • Unit and integration tests covering the common scenarios were added

jkaflik
jkaflik approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM. Please let me know if you want to reiterate on my review's comments.

tests/ipv6_test.go Outdated Show resolved Hide resolved
tests/ipv6_test.go Outdated Show resolved Hide resolved
tests/ipv6_test.go Outdated Show resolved Hide resolved
@jkaflik jkaflik merged commit 78780a8 into ClickHouse:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaflik jkaflik jkaflik approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisismaple @jkaflik