Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expire idle connections no longer acquired during lifetime #945

Merged
merged 13 commits into from
Mar 31, 2023
Merged

Expire idle connections no longer acquired during lifetime #945

merged 13 commits into from
Mar 31, 2023

Conversation

jkaflik
Copy link
Contributor

@jkaflik jkaflik commented Mar 28, 2023 •
edited
Loading

Summary

Expire idle connections no longer acquired during lifetime. Adds a goroutine that closes a connection after ConnMaxLifetime duration.

solves #940

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • Expire idle connections no longer acquired during lifetime.

@jkaflik jkaflik mentioned this pull request Mar 28, 2023
Closed
@jkaflik jkaflik marked this pull request as ready for review March 28, 2023 13:30
@mshustov mshustov requested a review from genzgd March 29, 2023 08:11
@jkaflik jkaflik merged commit 0d10a70 into main Mar 31, 2023
@jkaflik jkaflik mentioned this pull request Mar 31, 2023
Closed
jkaflik added a commit that referenced this pull request Apr 3, 2023
@jkaflik
Revert "Expire idle connections no longer acquired during lifetime (#945
0668371 
)"

This reverts commit 0d10a70.
@jkaflik jkaflik mentioned this pull request Apr 3, 2023
Merged
jkaflik added a commit that referenced this pull request Apr 3, 2023
@jkaflik
Revert "Expire idle connections no longer acquired during lifetime (#945
dd94572 
)" (#958)

This reverts commit 0d10a70.
@jkaflik jkaflik deleted the expire-idle-conns branch May 5, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genzgd genzgd genzgd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkaflik @genzgd