Better handling for connection errors in the std interface #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkaflik I think this is the other piece of the puzzle, at least for the std interface: with this patch in place on our side and debugging enabled, resetting a server node results in one EOF error logged per active connection, no "context cancelled" errors, and an immediate recovery. |
n-oden
force-pushed
the
add-more-logging-std
branch
from
1ede73c to
edbf10e
Compare
jkaflik
reviewed
Jan 27, 2023
n-oden
force-pushed
the
add-more-logging-std
branch
2 times, most recently
from
3a1df47 to
e7a9e51
Compare
- check for EOF/EPIPE errors in the major functions of clickhouse_std.go and explicitly return driver.ErrBadConn when we catch them - add debug logging of most error conditions to the std interface, following the existing pattern for error handling Signed-off-by: Nathan J. Mehl <n@oden.io>
n-oden
force-pushed
the
add-more-logging-std
branch
from
e7a9e51 to
5828ef5
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check for EOF/EPIPE errors in the major functions of clickhouse_std.go and explicitly return driver.ErrBadConn when we catch them
add debug logging of most error conditions to the std interface, following the existing pattern for error handling
Signed-off-by: Nathan J. Mehl n@oden.io