Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #848 (quoted column name in INSERT INTO) #849

Closed
wants to merge 1 commit into from

Conversation

wizzard0
Copy link
Contributor

Closes #848 by unquoting column names similar to how the brackets are currently parsed %)

@jkaflik
Copy link
Contributor

jkaflik commented Dec 13, 2022

@wizzard0
Thanks for your contribution. Are you able to provide a test case that covers this issue?
Reference: https://github.com/ClickHouse/clickhouse-go/blob/b78c9faca931f7df673c8f7b63ffba945e121502/tests/issues

Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test case if possible

@wizzard0
Copy link
Contributor Author

@jkaflik Sure, I'll get back to it a bit later, have to finish some other tasks rn

@jkaflik
Copy link
Contributor

jkaflik commented Dec 22, 2022

@wizzard0 do you think you would be able to work on this soon?

@wizzard0
Copy link
Contributor Author

@jkaflik I'm working thru backlog that's accumulated recently because of the blackouts in Kyiv. Don't want to make promises bc blackouts can easily return anytime. So yes I want to, but right now it's not really under my control.

@jkaflik
Copy link
Contributor

jkaflik commented Dec 22, 2022

@wizzard0 absolutely, no pressure. I will try to have a look at it by myself in my spare time if needed.

@jkaflik
Copy link
Contributor

jkaflik commented Feb 20, 2023

My bad. This was already fixed in #829 and already reported in #828. Closing it.

@jkaflik jkaflik closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insert into table (field1,field2) VALUES ('a', 'b') -> "column field1 is not present"
2 participants