-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clickable breadcrumbs #2779
Open
Blargian
wants to merge
18
commits into
ClickHouse:main
Choose a base branch
from
Blargian:menu-improvement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Clickable breadcrumbs #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocsCheck fails:
This is because the former is added in #71846 over at main repo and the latter because May also need to add a redirect for that. |
Blargian
force-pushed
the
menu-improvement
branch
from
December 16, 2024 22:26
fe184ca
to
c68b309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2636. Introduces changes to clean up the navigation of docs together with 71846 over on main repo.
PR will fail due to two missing files which were added in the PR on the main repo
Changes
In many places we show an overview page as a sub-child of the category, such as here:
In my opinion this clutters the sidebar, especially when the overview page has the same name as the category. This PR makes a small change to the
sidebarItemsGenerator
such that any file endingindex.md
will not show as a sub-child of the category. The category itself is then given the link to the overview or index page and becomes clickable:Further more, breadcrumbs often did not link to anywhere such as here, because 'introduction' was a category and not a specific page:
Index files are added (in a separate PR) in some places and categories in the sidebar linked such that breadcrumbs are clickable:
Also addresses 2888, adding landing pages where they are missing.
Checklist