Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speedup 128|256 bit integers #10

Merged
merged 1 commit into from
Dec 30, 2021
Merged

feat: speedup 128|256 bit integers #10

merged 1 commit into from
Dec 30, 2021

Conversation

ernado
Copy link
Collaborator

@ernado ernado commented Dec 30, 2021

name                           old time/op    new time/op     delta
ColDecimal128_DecodeColumn-32    2.58µs ± 5%     0.25µs ± 2%   -90.25%  (p=0.008 n=5+5)
ColDecimal256_DecodeColumn-32    3.56µs ± 3%     0.70µs ± 1%   -80.42%  (p=0.008 n=5+5)
ColInt128_DecodeColumn-32        2.52µs ± 1%     0.25µs ± 1%   -90.03%  (p=0.008 n=5+5)
ColInt256_DecodeColumn-32        3.49µs ± 1%     0.71µs ± 2%   -79.72%  (p=0.008 n=5+5)
ColUInt128_DecodeColumn-32       2.54µs ± 3%     0.25µs ± 1%   -90.16%  (p=0.008 n=5+5)
ColUInt256_DecodeColumn-32       3.59µs ± 1%     0.69µs ± 1%   -80.66%  (p=0.008 n=5+5)

name                           old speed      new speed       delta
ColDecimal128_DecodeColumn-32  6.21GB/s ± 5%  63.70GB/s ± 2%  +925.56%  (p=0.008 n=5+5)
ColDecimal256_DecodeColumn-32  8.99GB/s ± 3%  45.91GB/s ± 1%  +410.60%  (p=0.008 n=5+5)
ColInt128_DecodeColumn-32      6.36GB/s ± 1%  63.77GB/s ± 1%  +903.17%  (p=0.008 n=5+5)
ColInt256_DecodeColumn-32      9.17GB/s ± 1%  45.20GB/s ± 2%  +393.14%  (p=0.008 n=5+5)
ColUInt128_DecodeColumn-32     6.30GB/s ± 3%  63.95GB/s ± 1%  +915.68%  (p=0.008 n=5+5)
ColUInt256_DecodeColumn-32     8.92GB/s ± 1%  46.12GB/s ± 1%  +417.03%  (p=0.008 n=5+5)

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #10 (e044260) into main (beb3a3c) will decrease coverage by 0.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   81.79%   81.31%   -0.49%     
==========================================
  Files         103      103              
  Lines        4219     4179      -40     
==========================================
- Hits         3451     3398      -53     
- Misses        627      640      +13     
  Partials      141      141              
Impacted Files Coverage Δ
proto/col_ipv4_safe_gen.go 100.00% <ø> (ø)
proto/col_decimal128_unsafe_gen.go 100.00% <100.00%> (ø)
proto/col_decimal256_unsafe_gen.go 100.00% <100.00%> (ø)
proto/col_int128_unsafe_gen.go 100.00% <100.00%> (ø)
proto/col_int256_unsafe_gen.go 100.00% <100.00%> (ø)
proto/col_uint128_unsafe_gen.go 100.00% <100.00%> (ø)
proto/col_uint256_unsafe_gen.go 100.00% <100.00%> (ø)
proto/int256.go 42.10% <0.00%> (-34.22%) ⬇️
proto/col_decimal128_safe_gen.go
proto/col_decimal256_safe_gen.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb3a3c...e044260. Read the comment docs.

@ernado ernado merged commit 23012ce into main Dec 30, 2021
@ernado ernado deleted the feat/128-256-speedup branch January 6, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant