-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X-ClickHouse-Exception-Code in HTTP Header #8786
Merged
alexey-milovidov
merged 13 commits into
ClickHouse:master
from
millb:X-ClickHouse-Exception-Code
Jan 26, 2020
Merged
X-ClickHouse-Exception-Code in HTTP Header #8786
alexey-milovidov
merged 13 commits into
ClickHouse:master
from
millb:X-ClickHouse-Exception-Code
Jan 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b/ClickHouse into X-ClickHouse-Exception-Code
alexey-milovidov
changed the title
[WIP] X-Click-House-Exception-Code in HTTP Header
[WIP] X-ClickHouse-Exception-Code in HTTP Header
Jan 22, 2020
millb
changed the title
[WIP] X-ClickHouse-Exception-Code in HTTP Header
X-ClickHouse-Exception-Code in HTTP Header
Jan 24, 2020
alexey-milovidov
approved these changes
Jan 25, 2020
@BayoNet lets add a place in docs with all headers list and explanation? Do we have a ticket for that? |
Not sure it's working. It's working sometimes.
|
@den-crane HTTP headers cannot be sent after data.
|
Ah, OK. I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added
X-ClickHouse-Exception-Code
HTTP header that is set if exception was thrown before sending data. This implements #4971....
Detailed description / Documentation draft:
...
By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.
If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.