Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry coordination error when loading tables #76020

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Conversation

tavplubix
Copy link
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Retry coordination errors when loading tables

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Copy link
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZooKeeperRetriesControl is crying in a corner. Would it be possible to use that instead?

@tavplubix
Copy link
Member Author

It would require wrapping a ZooKeeper object into ZooKeeperRetriesControl and passing it through the whole stack from loadTableFromMetadata to all places that use ZooKeeper inside. Alternatively, we can attach ZooKeeperRetriesControl to local_context (so at least we will not have to modify signatures of many functions in the middle to pass it), but it doesn't look much better

Copy link

clickhouse-gh bot commented Feb 13, 2025

Workflow [PR], commit [f4b55fd]

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Feb 13, 2025
@antonio2368 antonio2368 self-assigned this Feb 17, 2025
@tavplubix tavplubix added this pull request to the merge queue Feb 17, 2025
Merged via the queue into master with commit 6e047a1 Feb 17, 2025
118 of 121 checks passed
@tavplubix tavplubix deleted the retry_table_loading branch February 17, 2025 16:01
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants