Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of TRIM with computed trim characters #75399

Merged
merged 11 commits into from
Feb 12, 2025

Conversation

mgill25
Copy link
Contributor

@mgill25 mgill25 commented Feb 3, 2025

Resolves #69922

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Function TRIM with computed empty trim characters are now correctly handled. Example: SELECT TRIM(LEADING concat('') FROM 'foo') (Issue #69922)

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Feb 3, 2025
@rschu1ze rschu1ze self-assigned this Feb 3, 2025
@rschu1ze rschu1ze added the can be tested Allows running workflows for external contributors label Feb 3, 2025
@mgill25 mgill25 requested a review from rschu1ze February 4, 2025 20:29
@mgill25 mgill25 marked this pull request as ready for review February 4, 2025 20:29
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Feb 4, 2025

This is an automated comment for commit 8106675 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
BuzzHouse (asan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (debug)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (msan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (tsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (ubsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@mgill25 mgill25 changed the title TrimFunction to replace the Regular expression based implementation TrimFunction to replace the Regular expression based TRIM implementation Feb 4, 2025
@mgill25

This comment was marked as resolved.

@mgill25

This comment was marked as resolved.

@rschu1ze

This comment was marked as resolved.

@mgill25

This comment was marked as resolved.

Copy link

clickhouse-gh bot commented Feb 10, 2025

Workflow [PR], commit [19eef40]

@rschu1ze rschu1ze changed the title TrimFunction to replace the Regular expression based TRIM implementation Fix behavior of TRIM with computed trim characters Feb 10, 2025
@rschu1ze

This comment was marked as resolved.

@rschu1ze
Copy link
Member

Stateless tests (azure, asan, 1/3):

Integration tests (release, 4/4):

@rschu1ze rschu1ze added this pull request to the merge queue Feb 12, 2025
Merged via the queue into ClickHouse:master with commit a33882e Feb 12, 2025
116 of 123 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRIM does not support empty trim characters, pt. II
4 participants