-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix behavior of TRIM
with computed trim characters
#75399
Merged
rschu1ze
merged 11 commits into
ClickHouse:master
from
mgill25:mgill25/better-trim-function
Feb 12, 2025
Merged
Fix behavior of TRIM
with computed trim characters
#75399
rschu1ze
merged 11 commits into
ClickHouse:master
from
mgill25:mgill25/better-trim-function
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
This is an automated comment for commit 8106675 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
TRIM
implementation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
rschu1ze
reviewed
Feb 9, 2025
rschu1ze
reviewed
Feb 9, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
TRIM
implementationTRIM
with computed trim characters
This comment was marked as resolved.
This comment was marked as resolved.
Stateless tests (azure, asan, 1/3):
Integration tests (release, 4/4):
|
Merged
via the queue into
ClickHouse:master
with commit Feb 12, 2025
a33882e
116 of 123 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-bugfix
Pull request with bugfix, not backported by default
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #69922
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Function
TRIM
with computed empty trim characters are now correctly handled. Example:SELECT TRIM(LEADING concat('') FROM 'foo')
(Issue #69922)