Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in protobuf schema cache #75357

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

Avogar
Copy link
Member

@Avogar Avogar commented Jan 31, 2025

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix crash in protobuf schema cache that can happen during output in Protobuf format and parallel query SYSTEM DROP FORMAT SCHEMA CACHE

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory and will run independently of the checks below:

  • Only: Stateless tests
  • Only: Integration tests
  • Only: Performance tests

  • Skip: Style check
  • Skip: Fast test

  • Run all checks ignoring all possible failures (Resource-intensive. All test jobs execute in parallel).
  • Disable CI cache

@robot-ch-test-poll3 robot-ch-test-poll3 added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Jan 31, 2025
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Jan 31, 2025

This is an automated comment for commit f503399 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ error
Successful checks
Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (asan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (debug)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (msan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (tsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (ubsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antaljanosbenjamin antaljanosbenjamin self-assigned this Jan 31, 2025
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
@Avogar Avogar added this pull request to the merge queue Feb 7, 2025
Merged via the queue into ClickHouse:master with commit a561de2 Feb 7, 2025
169 of 174 checks passed
@Avogar Avogar deleted the fix-protobuf-schema-race branch February 7, 2025 19:09
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 7, 2025
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 7, 2025
Cherry pick #75357 to 24.8: Fix crash in protobuf schema cache
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 7, 2025
Cherry pick #75357 to 24.11: Fix crash in protobuf schema cache
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 7, 2025
Cherry pick #75357 to 24.12: Fix crash in protobuf schema cache
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 7, 2025
Cherry pick #75357 to 25.1: Fix crash in protobuf schema cache
robot-ch-test-poll4 added a commit that referenced this pull request Feb 7, 2025
Backport #75357 to 25.1: Fix crash in protobuf schema cache
robot-ch-test-poll3 added a commit that referenced this pull request Feb 7, 2025
Backport #75357 to 24.12: Fix crash in protobuf schema cache
Avogar added a commit that referenced this pull request Feb 10, 2025
Backport #75357 to 24.11: Fix crash in protobuf schema cache
Avogar added a commit that referenced this pull request Feb 10, 2025
Backport #75357 to 24.8: Fix crash in protobuf schema cache
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants