Avoid reusing columns among different named tuples

[amosbird]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Avoid reusing columns among different named tuples when evaluating tuple functions. This fixes #70022

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

• Allow: All Required Checks
• Allow: Stateless tests
• Allow: Stateful tests
• Allow: Integration Tests
• Allow: Performance tests
• Allow: All Builds
• Allow: batch 1, 2 for multi-batch jobs
• Allow: batch 3, 4, 5, 6 for multi-batch jobs

---

• Exclude: Style check
• Exclude: Fast test
• Exclude: All with ASAN
• Exclude: All with TSAN, MSAN, UBSAN, Coverage
• Exclude: All with aarch64, release, debug

---

• Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
• Exclude: AST fuzzers

---

• Do not test
• Woolen Wolfdog
• Upload binaries for special builds
• Disable merge-commit
• Disable CI cache

[robot-clickhouse]

This is an automated comment for commit e843bb9 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Bugfix validation	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	✅ success
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

[novikd]

This will likely not work in the distributed case because the query on the follower node won't have AS col_a and AS col_b for the tuple function argument. I think a proper fix would also include creating a cast operation.

[novikd]

Also, I think that such code should check enable_named_columns_in_function_tuple setting.

[amosbird]

This will likely not work in the distributed case because the query on the follower node won't have AS col_a and AS col_b for the tuple function argument. I think a proper fix would also include creating a cast operation.

It works because we do addConvertingActions in ReadFromRemote step. I've added a test case to verify this.

Also, I think that such code should check enable_named_columns_in_function_tuple setting.

Sure.

[alexey-milovidov]

Missing escaping.

[Algunenano]

A case that's not covered by this fix:

DROP TABLE IF EXISTS src;
DROP TABLE IF EXISTS target;
SET flatten_nested = 0;

CREATE TABLE src
(
    id UInt64,
    minmax Nested(
        min Float64,
        max Float64,
    )
)
ENGINE = MergeTree
ORDER BY (id);

CREATE TABLE target AS src;


INSERT INTO src VALUES (0, [(-10, 10)]);


INSERT INTO target
SELECT
    id,
    groupArray(tuple(bucket_min, bucket_max))
FROM
(
    SELECT
        id,
        minmax.1 AS bucket_min,
        minmax.2 AS bucket_max
    FROM
    (
        select
            id, arrayJoin(minmax) as minmax
        FROM src
    )
)
GROUP BY id;

SELECT * FROM target;

$ clickhouse local --queries-file repro.sql --enable_named_columns_in_function_tuple=0
0       [(-10,10)]
$ clickhouse local --queries-file repro.sql --enable_named_columns_in_function_tuple=1
0       [(0,0)]

I'm going to disable with setting by default (and backport) in the meantime.

[amosbird]

A case that's not covered by this fix:

create table x (t Tuple(a int, b int)) engine MergeTree order by ();
insert into x select (1 as a2, 2 as b2);
select * from x format JSONEachRow;

{"t":{"a":0,"b":0}}

We never support inserting Tuple(a2 int, b2 int) into Tuple(a int, b int), but it's fine to insert Tuple(int, int) into Tuple(a int, b int). I'm not sure what's the expected behavior. Maybe we should keep this feature disabled by default?

[rschu1ze]

Just for reference: Setting enable_named_columns_in_function_tuple was disabled here: #70833

[alexey-milovidov]

@amosbird, please enable it back in a subsequent pull request.

[amosbird]

please enable it back in a subsequent pull request.

@alexey-milovidov Sure. I'll mention this backward incompatibility in the following PR #70103 (comment)