-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data-dependent bug with some formatters offormatDateTimeInJodaSyntax
#64614
Merged
alexey-milovidov
merged 3 commits into
ClickHouse:master
from
liuneng1994:fix_formatDateTimeInJodaSyntax
Jun 1, 2024
Merged
Fix data-dependent bug with some formatters offormatDateTimeInJodaSyntax
#64614
alexey-milovidov
merged 3 commits into
ClickHouse:master
from
liuneng1994:fix_formatDateTimeInJodaSyntax
Jun 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll2
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
May 30, 2024
Contributor
This is an automated comment for commit 7faafec with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
This comment was marked as resolved.
This comment was marked as resolved.
rschu1ze
changed the title
Fix formatDateTimeInJodaSyntax result error
Fix data-dependent bug with some formatters ofMay 31, 2024
formatDateTimeInJodaSyntax
@liuneng1994 Nice fix, thanks. If I see correctly, the chance of hitting it with formatter |
rschu1ze
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-bugfix
Pull request with bugfix, not backported by default
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64613
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix the output of function
formatDateTimeInJodaSyntax
when a formatter generates an uneven number of characters and the last character is0
. For example,SELECT formatDateTimeInJodaSyntax(toDate('2012-05-29'), 'D')
now correctly returns150
instead of previously15
.Documentation entry for user-facing changes