-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit a warning in clickhouse-client if Ordinary database engine is used #56942
Conversation
Marina Fathouat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This is an automated comment for commit 225775f with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
An integration test is needed. |
Fixing use of capitals in user message "Server has databases with Ordinary engine, which is not optimal."
It can be a simple stateless functional test. We should prefer functional tests over integration tests when possible |
removed space at the beginning of the line
This reverts commit 06ef0d2.
Functional tests - all failing in master, will take a closer look after merging. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Ordinary database engine is deprecated. You will receive a warning in clickhouse-client if your server is using it. This closes #52229