Fix statx on ARM #47008
Merged
Fix statx on ARM #47008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-1
added
the
pr-build
|
Still verifying if the fix helps. I also consider a binary compatibility check for ARM, similar to the existing one. |
|
Verified, works. Will add the compat check for ARM in a separate PR. |
alexey-milovidov
approved these changes
Mar 1, 2023
rschu1ze
added
the
pr-must-backport
|
Yes, the struct layout is the same across different platforms. InstallPackagesTestRelease:
ClickHouse Stateless Tests (ubsan) [2/2]:
|
This was referenced Mar 1, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Mar 1, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Mar 1, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Mar 1, 2023
robot-ch-test-poll2
added
the
pr-backports-created
rschu1ze
added a commit
that referenced
this pull request
Mar 1, 2023
Backport #47008 to 22.12: Fix statx on ARM
rschu1ze
added a commit
that referenced
this pull request
Mar 1, 2023
Backport #47008 to 23.2: Fix statx on ARM
rschu1ze
added a commit
that referenced
this pull request
Mar 1, 2023
Backport #47008 to 23.1: Fix statx on ARM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46055
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix error during server startup on old distros (e.g. Amazon Linux 2) and on ARM that glibc 2.28 symbols are not found