Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version I had removed
@allowscalar
frombecause I thought
minimum(::CuArray)
does not incur inscalarindexing
problems.In this way I could remove the dependency of this package on CUDA.
Apparently
minimum(::OffsetArrays)
does indeed incur inscalarindexing
problems, so this PR reintroduces CUDA in the dependencies just because of this@allowscalar
.