Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(0.91.13) Use SeawaterPolynomials 0.3.5 #3767

Merged
merged 3 commits into from
Sep 8, 2024
Merged

(0.91.13) Use SeawaterPolynomials 0.3.5 #3767

merged 3 commits into from
Sep 8, 2024

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Sep 7, 2024 •
edited
Loading

This PR bumps SeawaterPolynomials 0.3.5 and fixes a doctest. The changes in this PR would remedy the docs built failing in #3766.

@navidcy navidcy added the package 📦 Quite meta label Sep 7, 2024
glwagner
glwagner approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to bump the Oceananigans patch version too

@glwagner glwagner changed the title Use SeawaterPolynomials 0.3.5 (0.91.13) Use SeawaterPolynomials 0.3.5 Sep 8, 2024
@navidcy
Copy link
Collaborator Author

navidcy commented Sep 8, 2024

https://buildkite.com/clima/oceananigans-distributed/builds/3302#0191d361-d24d-43dc-b973-f7e4c2548747/7-11

Running global environment hook
$ /groups/esm/slurm-buildkite/hooks/environment
/usr/bin/whoami: cannot find name for user ID 29706
pdsh@hpc-35-36: who are you?

Existential questions from Caltech HPC....

@glwagner
Copy link
Member

glwagner commented Sep 8, 2024

I. Am. Oceananigans.

@navidcy navidcy merged commit 6d1d503 into main Sep 8, 2024
46 checks passed
@navidcy navidcy deleted the ncc/seawaterpolynomials-0.3.5 branch September 8, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

@siddharthabishnu siddharthabishnu Awaiting requested review from siddharthabishnu

@tomchor tomchor Awaiting requested review from tomchor

@simone-silvestri simone-silvestri Awaiting requested review from simone-silvestri

Assignees
No one assigned
Labels
package 📦 Quite meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navidcy @glwagner