-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension feature for plotting fields when nodes are provided #3715
Conversation
Like which code? I mean what's an example that benefits from what changed here so I can test it to approve? |
This PR supports this kind of code: c = Field{Center, Center, Nothing}(grid)
x, y, z = nodes(c)
heatmap(x, y, c) The coordinates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM!
For future, we might wanna consider making this work:
c = CenterField(grid)
x, y, z = nodes(c)
heatmap(x, y, view(c, :, :, 1))
or
heatmap(x, z, view(c, :, 2, :))
I take it back! What I suggested actually works! |
This PR supports this syntax I thought |
Ah yeah. I didn't put |
I noticed that there was code in the grids tutorial that could benefit from this feature.