Removing some advection schemes #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
approved these changes
Jul 23, 2024
|
There is some problem with Enzyme here, which is weird because this PR only removes code does not add anything new |
|
That's good to find. Try updating the manifest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These schemes are dominated (in terms of both accuracy and speed) by the default methods and, since they should not be used because they are always a worst option, it makes sense to remove them not to continue maintaining them.
These are:
OnySelfUpwindingandCrossandSelfUpwinding)Thus, this PR removes these methods