-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(0.90.10) on_architecture
method for all Oceananigans' types
#3490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not expect to see 88 files changed --- but it indicates the importance of this. Are we also deprecating arch_array
? This would break a lot of existing code, but could be a positive change. Or we can deprecate sometime in the future (maybe we can issue a deprecation warning)
|
I think we can keep |
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
… into ss/on-architecture
I liked the idea of keeping a list of deprecated functions that will be removed after a couple of releases. |
on_architecture
method for all Oceananigans' typeson_architecture
method for all Oceananigans' types
@simone-silvestri when tests pass, is this ready to be merged? |
Should be |
We have two functions called
arch_array
andon_architecture
that pretty much do the same thing: moving a variable between GPU and CPU. However, neither of them covers all the types in Oceananigans, likeFields
orModels
.So, this PR tidies things up a bit. It removes
arch_array
in favor ofon_architecture
. In addition, it extendson_architecture
to all the types with memory-allocated variables.