Changes wet/dry to active/inactive #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
approved these changes
Feb 13, 2023
glwagner
reviewed
Feb 15, 2023
| # agents: | ||
| # queue: Oceananigans | ||
| # architecture: GPU | ||
| # depends_on: "init_gpu" |
There was a problem hiding this comment.
Does this PR affect anything to do with the regression test?
There was a problem hiding this comment.
@glwagner's point is fair! We should add it back asap! I have second thoughts now about commenting it out...
There was a problem hiding this comment.
A test that fails probably means something!
There was a problem hiding this comment.
If you look at PR #2924 the tests pass there, so it is strong evidence that it is a synchronization issue. We should readd it in lowering the number of time steps although that will only mask the problem in my opinion. Since a lot of PRs have already been merged with the test commented out, I suggest merging #2888 and then halting merging until we regenerate the data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2880, closes #2833