-
Notifications
You must be signed in to change notification settings - Fork 190
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(v0.85.0) Switching cells where fluxes are applied in `ImmersedBounda…
…ryCondition` to match `FieldBoundaryConditions`' kwargs (#3142) * test it out * Elaborate on ImmersedBoundaryCondition in the docs * Update docs/src/model_setup/boundary_conditions.md Co-authored-by: Tomas Chor <tomaschor@gmail.com> * added warning when using ImmersedBonudaryCOndition * Bump minor version (since this release is breaking for anyone using IBC) * add warnings to doctest * change warning --------- Co-authored-by: Gregory Wagner <wagner.greg@gmail.com> Co-authored-by: Tomas Chor <tomaschor@gmail.com>
- Loading branch information
1 parent
8634ef1
commit a1f4f4e
Showing
3 changed files
with
31 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1f4f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we register this?
a1f4f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearly. Who merged it?
a1f4f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The person who merged it should register.
a1f4f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuliaRegistrator register
a1f4f4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Registration pull request created: JuliaRegistries/General/87549
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via: