Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "NetCDF" to "0.11" #36

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 3, 2021

This pull request changes the compat entry for the NetCDF package from 0.10 to 0.10, 0.11.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@Yujie-W Yujie-W force-pushed the compathelper/new_version/2021-02-03-00-09-49-546-4180069210 branch from 955ce76 to c0ea831 Compare February 3, 2021 00:12
@Yujie-W
Copy link
Collaborator

Yujie-W commented Feb 3, 2021

Do not merge this to main until the bug of NetCDF v0.11 has been fixed. The bug is related to netcdf v4.7.4. For some reason, it fails to read UInt16 (as a result, grdding the MODIS data using NetCDF v0.11 does not work). See JuliaGeo/NetCDF.jl#138 for more details

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #36 (27d8da4) into main (539eae9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   44.01%   44.01%           
=======================================
  Files          21       21           
  Lines         643      643           
=======================================
  Hits          283      283           
  Misses        360      360           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 539eae9...c0ea831. Read the comment docs.

@Yujie-W Yujie-W closed this Apr 5, 2021
@Yujie-W Yujie-W deleted the compathelper/new_version/2021-02-03-00-09-49-546-4180069210 branch April 5, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant