Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TROPIC04 to AIDA calibrations #520

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding TROPIC04 to AIDA calibrations #520

wants to merge 2 commits into from

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Feb 26, 2025

Purpose

  • adding TROPIC04 experiment 4, ACI04_22, EXP19, EXP45, and EXP28 to AIDA ice nuc calibrations
  • TROPIC04 experiment 4 added to HOM batch

To-do

  • initial conditions and params for ACI04_22, EXP19, EXP45, and EXP28
  • revamp plotting code in AIDA_calibrations.jl to cater to .csv files whose start and end time indices are the same as the start and end time (no need for .- 100)
  • rename this PR/branch to account for the other newly added experiments if possible

Content


  • I have read and checked the items on the review checklist.

@amylu00 amylu00 self-assigned this Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (30ab36d) to head (542e404).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          42       42           
  Lines        1615     1615           
=======================================
  Hits         1544     1544           
  Misses         71       71           
Components Coverage Δ
src 97.23% <ø> (ø)
ext 69.79% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant