Remove DiffEqCallbacks from src #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/diffeqcallbacks
branch
6 times, most recently
from
f82e0cc
to
5ba9419
Compare
The only place where DiffEqCallbacks was used is to use SavedValues, but SavedValues is only used in NonInterplatingSavingCallback. Here, I copied over the definition of SavedValues from DiffEqCallbacks and removed the direct dependency. There is still some dependency in the tests, but that can be removed too if a small amount of work.
Sbozzolo
force-pushed
the
gb/diffeqcallbacks
branch
from
5ba9419
to
1f74d86
Compare
charleskawczynski
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only place where DiffEqCallbacks was used is to use SavedValues, but SavedValues is only used in NonInterplatingSavingCallback. Here, I copied over the definition of SavedValues from DiffEqCallbacks and removed the direct dependency.
There is still some dependency in the tests, but that can be removed too with a small amount of work.
Closes #304
Closes #248