Add post stage callback #190
Conversation
src/solvers/imex_ssprk.jl
Outdated
| @@ -144,6 +146,9 @@ function step_u!(integrator, cache::IMEXSSPRKCache) | |||
| T_exp!(T_exp, U, p, t_exp) | |||
| end | |||
| end | |||
| dss!(p, U_imp, t_imp) # mutate state (e.g., dss! + BCs) | |||
There was a problem hiding this comment.
@dennisYatunin, should we be dss-ing the implicit part in the imex ssprk?
There was a problem hiding this comment.
No, we should not add another dss call here. For both IMEX-ARK and IMEX-SSPRK, we only need the two dss calls outlined in the docs: one when computing the residual for the implicit solve on each stage, and another at the end of the timestep.
There was a problem hiding this comment.
In both cases, dss! can be replaced with a generic filter!, since the reasoning given here is not specific to dss.
There was a problem hiding this comment.
Ok, I've called it apply_filter! (to avoid name collisions with Base.filter!), does that sound okay? We could alternatively adopt OrdinaryDiffEq's name affect!
charleskawczynski
force-pushed
the
ck/post_cb
branch
2 times, most recently
from
5d4af80
to
89f922c
Compare
|
For the ARK ones, it would probably make sense to have |
charleskawczynski
force-pushed
the
ck/post_cb
branch
from
89f922c
to
97e9425
Compare
I did that originally, but we also need to call it in |
charleskawczynski
force-pushed
the
ck/post_cb
branch
4 times, most recently
from
a8d312c
to
658cd9f
Compare
Fix compat
charleskawczynski
force-pushed
the
ck/post_cb
branch
from
658cd9f
to
94fbcc4
Compare
| (; post_explicit_stage_callback!) = prob.f | ||
| if !isnothing(post_explicit_stage_callback!) | ||
| post_explicit_stage_callback!(AlgMeta(:init), u0, p, t0) | ||
| end |
There was a problem hiding this comment.
| (; post_explicit_stage_callback!) = prob.f | |
| if !isnothing(post_explicit_stage_callback!) | |
| post_explicit_stage_callback!(AlgMeta(:init), u0, p, t0) | |
| end | |
| pscb = prob.f.post_explicit_stage_callback! | |
| isnothing(pscb) || pscb(AlgMeta(:init), u0, p, t0) |
|
Superseded by #210 |
This PR:
dss!toapply_filter!, being that this function will be used to calldss!and (potentially) applying boundary conditions.post_stage_callback!, which is called afterapply_filter!and is also called insidesolve_newton!to ensure thatpost_stage_callback!is called between newton iterations.Closes #193.