Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old code, update docs, add explicit algs #166

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Remove old code, update docs, add explicit algs #166

merged 1 commit into from
Jan 30, 2023

Conversation

dennisYatunin
Copy link
Member

Purpose

This PR removes the old ark.jl and ssprk.jl files.

Content

  • Remove ark.jl and ssprk.jl
  • Extend the new interface to allow an ExplicitTableau and an ExplicitAlgorithm (both of which just call IMEXTableau and IMEXAlgorithm under the hood)
  • Port old tableaus to new interface (certain SSPRK tableaus could not be ported because the new interface only allows a single vector of coefficients β, whereas the old implementation allowed two vectors of coefficients)
  • Add a docstring for every tableau in the new interface, and update the bibliography with new entries
  • I have read and checked the items on the review checklist.

@dennisYatunin dennisYatunin force-pushed the dy/delete branch 3 times, most recently from 3a11185 to e66d59d Compare January 30, 2023 04:23
charleskawczynski
charleskawczynski reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer we stick with constraint over restricted

@dennisYatunin dennisYatunin changed the title Remove old ARK and SSPRK code Remove old code, update docs, add explicit algs Jan 30, 2023
@dennisYatunin
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 30, 2023

Build succeeded:

@bors bors bot merged commit e2c6ad9 into main Jan 30, 2023
@bors bors bot deleted the dy/delete branch January 30, 2023 12:00
@dennisYatunin dennisYatunin mentioned this pull request Jan 30, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisYatunin @charleskawczynski