Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deformational Flow Example #161

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Add Deformational Flow Example #161

merged 1 commit into from
Jan 21, 2023

Conversation

dennisYatunin
Copy link
Member

@dennisYatunin dennisYatunin commented Jan 13, 2023

Purpose

This PR was intended to demonstrate the correct convergence behavior of SSP methods with limiters, using the Deformational Flow test case from the DCMIP test case document. Unfortunately, it appears that neither ARK nor SSP algorithms converge when a non-trivial limiter is applied.

Closes #162

To-do

Determine whether the observed behavior is expected, or if there is a bug in either the test setup or the SSP implementation.

Content

The Deformational Flow test case has been ported over from ClimaAtmos, but simplified to more closely resemble the description in the DCMIP document. Specifically, density has been removed as a prognostic variable, and the equations have been converted to advective form. The test case can be run with three "limiter modes"---no limiter, the limiter used in ClimaCore, and a custom operation. The last option is helpful for testing out various simple alternatives, and it is currently set to rescale each tracer concentration field so that the total sum of the tracer mass remains constant.

Whenever the test case is run with no limiter, the correct convergence behavior is observed; this can be verified through the convergence order plot for this test case in the docs (located in Developer Docs/Report Generator). While this PR is in the testing phase, the plot only includes SSP333 and ARS343. Whenever a limiter is applied, the convergence order drops; it seems to drop to around 1 for very small values of dt with both current limiter options, but further testing is needed to be certain of this.


  • I have read and checked the items on the review checklist.

@dennisYatunin
Copy link
Member Author

Here are the plots for the convergence of SSP333 and ARS343 without any limiter and with the limiter from ClimaCore. Since the test case is currently fully explicit, we expect SSP333 to converge with order 3 and ARS343 to converge with order 4. The analytic solution is only defined at the start and end times, so the plots only show the solution/error norms at those times (even though the errors are computed against a numerical reference solution, that reference is still checked against the analytic solution).

convergence_deformational_flow_imex_algorithms_without_limiter

convergence_deformational_flow_imex_algorithms_with_limiter

@tapios
Copy link

tapios commented Jan 13, 2023

This is the expected behavior (Godunov's theorem)

@dennisYatunin
Copy link
Member Author

This PR has been updated to insert an analysis of IMEXAlgorithm with limiters into the documentation, recreating Table 1 from "Optimization-based limiters for the spectral element method" by Guba et al., along with plots of all the values used to generate Table 1. Should be good to merge once the documentation build succeeds.

@bischtob
Copy link

@dennisYatunin are we merging this by EOW?

@dennisYatunin
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jan 21, 2023
161: Add Deformational Flow Example r=dennisYatunin a=dennisYatunin



Co-authored-by: Dennis Yatunin <dyatun@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 21, 2023

Build failed:

@dennisYatunin
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 21, 2023

@bors bors bot merged commit d87d6dc into main Jan 21, 2023
@bors bors bot deleted the dy/deformational_flow branch January 21, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deformation flow example for SSP
3 participants