Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EDMF parameters. #48

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Add EDMF parameters. #48

merged 1 commit into from
Mar 8, 2021

Conversation

ilopezgp
Copy link
Contributor

@ilopezgp ilopezgp commented Mar 5, 2021

This PR adds the EDMF parameters, which will then be removed from ClimateMachine.jl.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #48 (cd25b83) into master (cd8e22b) will increase coverage by 3.71%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   78.10%   81.81%   +3.71%     
==========================================
  Files           7        7              
  Lines         137      165      +28     
==========================================
+ Hits          107      135      +28     
  Misses         30       30              
Impacted Files Coverage Δ
src/Atmos/atmos_parameters.jl 94.73% <100.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8e22b...0019712. Read the comment docs.

@ilopezgp ilopezgp force-pushed the il/add_edmf branch 2 times, most recently from edc08d9 to 5a2d39a Compare March 6, 2021 07:20
@ilopezgp
Copy link
Contributor Author

ilopezgp commented Mar 8, 2021

@charleskawczynski I think this is ready

@charleskawczynski
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 8, 2021

@bors bors bot merged commit 8fb34bc into master Mar 8, 2021
@bors bors bot deleted the il/add_edmf branch March 8, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants