Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear coefficients for Koop2000 ice nucleation #190

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Apr 12, 2024

Purpose

To-do

Content


  • I have read and checked the items on the review checklist.

@amylu00 amylu00 requested a review from trontrytel April 12, 2024 21:25
@amylu00 amylu00 self-assigned this Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (6996885) to head (d90b583).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files           2        2           
  Lines         134      134           
=======================================
  Hits          132      132           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trontrytel
Copy link
Member

@amylu00 - You will also want to bump the patch version and do a release to be able to use them in CM.jl

@nefrathenrici
Copy link
Member

Could you add an entry to the top of the NEWS.md as well?

@amylu00
Copy link
Member Author

amylu00 commented Apr 12, 2024

@amylu00 - You will also want to bump the patch version and do a release to be able to use them in CM.jl

I just bumped the patch version but I don't think I have permission to do a release?

@nefrathenrici
Copy link
Member

@amylu00 - You will also want to bump the patch version and do a release to be able to use them in CM.jl

I just bumped the patch version but I don't think I have permission to do a release?

Has @JuliaRegistrator register failed for you in the past?

@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

@amylu00
Copy link
Member Author

amylu00 commented Apr 12, 2024

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Error while trying to register: Register Failed
@amylu00, it looks like you are not a publicly listed member/owner in the parent organization (CliMA).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

@amylu00 amylu00 merged commit d19d043 into main Apr 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants