Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SoilCO2Model Land parameters #179

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Add SoilCO2Model Land parameters #179

merged 2 commits into from
Mar 7, 2024

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Feb 17, 2024

Adds the following parameters:
D_ref, D_liq, α_sx, Ea_sx, kM_sx, kM_o2, O2_a, D_oa, p_sx

These could use some better sourcing, but it may not be necessary.

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (3f8d151) to head (e9065c2).
Report is 1 commits behind head on main.

❗ Current head e9065c2 differs from pull request most recent head c8eb460. Consider uploading reports for the commit c8eb460 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files           2        2           
  Lines         134      134           
=======================================
  Hits          132      132           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kmdeck kmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that b and thetaa_100 are soil type dependent and should be read in from maps.
b is the "Absolute value of the slope of the line relating log(ψ) versus log(θ) (unitless)", but psi(theta) is the matric potential function which for sure depends on soil type/is not universal.
\theta a_100 is the "Air-filled porosity at soil water potential of -100 cm H₂O (~ 10 Pa)" which also depends on psi(theta) and should depend on soil type.

It would also be nice to add references for the default values that are used @AlexisRenchon what source do you use?

@nefrathenrici nefrathenrici merged commit 455b173 into main Mar 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants