Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default type, update docs #166

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Remove default type, update docs #166

merged 1 commit into from
Feb 7, 2024

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Feb 5, 2024

Content

  • Remove the default type and error if a parameter has no type
  • Add clearer docs for array parameters
  • Update test to match
  • Fix the formatter GHA update

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (110de02) 98.49% compared to head (2d61ca6) 98.50%.

❗ Current head 2d61ca6 differs from pull request most recent head e82b207. Consider uploading reports for the commit e82b207 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   98.49%   98.50%   +0.01%     
==========================================
  Files           2        2              
  Lines         133      134       +1     
==========================================
+ Hits          131      132       +1     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad we are removing the default here

NB seems like the formatter is failing, perhaps this needs to be rerun

@nefrathenrici nefrathenrici force-pushed the ne/rm_default_type branch 4 times, most recently from 1323fc2 to 2d61ca6 Compare February 7, 2024 20:21
@nefrathenrici nefrathenrici merged commit b0dbb7a into main Feb 7, 2024
7 checks passed
@nefrathenrici
Copy link
Member Author

@odunbar can we consider #144 closed with this PR? I think that this addresses the remaining points (array params and overrides)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants