Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds utilities for downloading and working with JRA55 data + remove IdealizedSimulations #54

Merged
merged 23 commits into from
Nov 3, 2023

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Nov 1, 2023

Also closes #53 .

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (84ff94e) 7.81% compared to head (6802dc7) 12.65%.

❗ Current head 6802dc7 differs from pull request most recent head 1a20124. Consider uploading reports for the commit 1a20124 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            main      #54      +/-   ##
=========================================
+ Coverage   7.81%   12.65%   +4.83%     
=========================================
  Files         12       11       -1     
  Lines        678      577     -101     
=========================================
+ Hits          53       73      +20     
+ Misses       625      504     -121     
Files Coverage Δ
src/ClimaOcean.jl 74.07% <ø> (+0.74%) ⬆️
src/DataWrangling/JRA55.jl 100.00% <100.00%> (ø)
src/NearGlobalSimulations/NearGlobalSimulations.jl 1.56% <ø> (ø)
src/DataWrangling/DataWrangling.jl 60.78% <60.78%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that somewhere around where RYF urls are defined let's add a comment that this is the Repeat-Year-Forcing from JRE55-do dataset and cite paper by Kial et al., doi:10.1016/j.ocemod.2019.101557.

@glwagner glwagner merged commit ef27621 into main Nov 3, 2023
2 checks passed
@glwagner glwagner deleted the glw/JRA55 branch November 3, 2023 07:02
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glwagner I want to resurrect these and use them
I'll put in a different repo?

@navidcy navidcy changed the title Adds utilities for downloading and working with JRA55 data Adds utilities for downloading and working with JRA55 data + remove IdealizedSimulations Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuke neverworld_simulation.jl
3 participants