Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit z-threads in columnwise_partition #1990

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Limit z-threads in columnwise_partition #1990

merged 1 commit into from
Sep 16, 2024

Conversation

charleskawczynski
Copy link
Member

This should re-close #1854.

@AlexisRenchon
Copy link
Member

I wanted to test it on caltech hpc GPU, but I am not sure what to do with:

[arenchon@hpc-25-24 .buildkite]$ julia --project
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.10.3 (2024-04-30)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

(.buildkite) pkg> dev ../../ClimaCore.jl/
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package ClimaDiagnostics [1ecacbb8]:
 ClimaDiagnostics [1ecacbb8] log:
 ├─possible versions are: 0.0.1-0.2.4 or uninstalled
 └─restricted to versions 0.2.5-0.2 by ClimaLand [08f4d4ce] — no versions left
   └─ClimaLand [08f4d4ce] log:
     ├─possible versions are: 0.14.4 or uninstalled
     └─ClimaLand [08f4d4ce] is fixed to version 0.14.4

@AlexisRenchon
Copy link
Member

Seems like something is outdated somewhere? ClimaDiagnostic 0.2.5 should exist

@Sbozzolo

@Sbozzolo
Copy link
Member

Seems like something is outdated somewhere? ClimaDiagnostic 0.2.5 should exist

@Sbozzolo

Try add ClimaDiagnostics@0.2.5

@AlexisRenchon
Copy link
Member

Seems like something is outdated somewhere? ClimaDiagnostic 0.2.5 should exist
@Sbozzolo

Try add ClimaDiagnostics@0.2.5

that worked

[arenchon@hpc-25-24 .buildkite]$ julia --project
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.10.3 (2024-04-30)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

(.buildkite) pkg> add ClimaDiagnostics@0.2.5
    Updating registry at `~/.julia/registries/General.toml`
   Resolving package versions...
  No Changes to `/central/home/arenchon/GitHub/ClimaLand.jl/.buildkite/Project.toml`
    Updating `/central/home/arenchon/GitHub/ClimaLand.jl/.buildkite/Manifest.toml`
  [8e850b90] ↓ libblastrampoline_jll v5.11.0+0 ⇒ v5.8.0+1

(.buildkite) pkg> dev ../../ClimaCore.jl/
   Resolving package versions...
    Updating `/central/home/arenchon/GitHub/ClimaLand.jl/.buildkite/Project.toml`
  [d414da3d] ~ ClimaCore v0.14.15 ⇒ v0.14.15 `../../ClimaCore.jl`
    Updating `/central/home/arenchon/GitHub/ClimaLand.jl/.buildkite/Manifest.toml`
  [d414da3d] ~ ClimaCore v0.14.15 ⇒ v0.14.15 `../../ClimaCore.jl`

@AlexisRenchon
Copy link
Member

The script that was crashing passes on this branch (on caltech hpc gpu).

What now? I imagine ClimaLand CI runs with latest release, so we need a ClimaCore release once this PR is merged?

@AlexisRenchon AlexisRenchon merged commit 4cda6fb into main Sep 16, 2024
23 of 24 checks passed
@AlexisRenchon AlexisRenchon deleted the ck/high_res branch September 16, 2024 16:55
@Sbozzolo
Copy link
Member

The script that was crashing passes on this branch (on caltech hpc gpu).

What now? I imagine ClimaLand CI runs with latest release, so we need a ClimaCore release once this PR is merged?

You can test that ClimaLand CI runs by explicitely checking this branch out.

  • Create a new branch in ClimaLand
  • Change the pipeline.yml files to pick this branch:
Pkg.add(url = "https://github.com/CliMA/ClimaCore.jl.git", rev = "ck/high_res")

in the instantiation steps

  • Manually trigger the builds you are interested in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Higher resolution column cases cannot be run on GPU
3 participants