Fix inference errors when not debugging #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
reviewed
Feb 20, 2024
charleskawczynski
force-pushed
the
ck/fix_inference
branch
from
3c6eccb
to
6e7d5fa
Compare
charleskawczynski
force-pushed
the
ck/fix_inference
branch
from
6e7d5fa
to
0e66ce6
Compare
dennisYatunin
approved these changes
Feb 20, 2024
charleskawczynski
force-pushed
the
ck/fix_inference
branch
4 times, most recently
from
cf77836
to
b76b299
Compare
charleskawczynski
force-pushed
the
ck/fix_inference
branch
2 times, most recently
from
f94d281
to
3647e06
Compare
Update src/MatrixFields/field_matrix_iterative_solver.jl Co-authored-by: Dennis Yatunin <dyatun@gmail.com> Fixes
charleskawczynski
force-pushed
the
ck/fix_inference
branch
from
3647e06
to
e394462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps some
@debugcalls inif get_debug(alg), so that we don't trigger compiler inference failures in code paths that we'll never reach.This should fix a lot of the inference errors we're seeing, due to KrylovKit.jl.
The diff looks a bit odd, but I'm only indenting.
This should allow us to see what remaining inference failures that we have in ClimaAtmos.