-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Base.cp
with run(...).
#69
Conversation
I think that this would break compatibility with windows |
One option is to merge this for now, revert to |
I think we can check for windows and use |
That's what I was thinking, too. I'm trying to run the example with |
It takes a long time downloading. The way I was monitoring it is by looking at the temporary file that gets created by Downloads (haing a better progress report would be very nice...). The warning is because you probably already have something in your directory. For this artifact (made of only one download file), it is harmless. |
793ec0a
to
05beb1c
Compare
`Base.cp` seems to have a bug when copying large files. Using `run` fixes this behaviour. This fixes the bug mentioned in #64
05beb1c
to
60ab4be
Compare
Replace
Base.cp
with run(...) on non-Windows operating systems.Base.cp
seems to have a bug when copying large files. Usingrun
fixes this behaviour.This fixes the bug mentioned in #64
Checklist:
$artifact_name
README.md
in that that folder thatLICENSE
fileProject.toml
and
Manifest.toml
)OutputArtifacts.toml
file containing the informationneeded for package developers to add
$artifact_name
to their package/groups/esm/ClimaArtifacts/artifacts/$artifact_name
)Overides.toml
on the Caltech Cluster(in
/groups/esm/ClimaArtifacts/artifacts/Overrides.toml
)README.md
to point to the new artifact