Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sleepiness_mod drugs to use effects.json #78685

Closed
TRScheel opened this issue Dec 20, 2024 · 7 comments
Closed

Update sleepiness_mod drugs to use effects.json #78685

TRScheel opened this issue Dec 20, 2024 · 7 comments
Labels
stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@TRScheel
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I believe it would be better if item id's pills_sleep, poppy_sleep, and chamomile_tea utilized effects.json for their sleepiness_mod modifiers.

Solution you would like.

Implement a new effect in effects.json such as hypnotics (see here for its medical definition) that these items use instead.

This would allow those drugs to better represent their real world counterparts. It would let CDDA model how they affect your mental/physical capabilities and how there is a real risk of death from overuse of them (ie. popping 100 at a time).

I am recommending a staggered reduction in:

  • Perception
  • Dexterity
  • Intelligence
  • Speed

Additionally, I'd put in a risk of death after a certain amount of use (to be determined).

Describe alternatives you have considered.

Could use the iuse.cpp methods for this but that hard codes all this and this feels like it should definitely be a json item. Alternatively, could just ignore it completely.

Additional context

I plan on implementing this myself (if approved ofc), just opening this up to discussion as to what values would make sense and be reasonable.

@TRScheel TRScheel added the <Suggestion / Discussion> Talk it out before implementing label Dec 20, 2024
@IdleSol
Copy link

IdleSol commented Dec 21, 2024

What will cause this effect? Drug-Effect or Drug-EOC-effect or Drug-vitamin-effect? Or other options?

@TRScheel
Copy link
Contributor Author

What will cause this effect? Drug-Effect or Drug-EOC-effect or Drug-vitamin-effect? Or other options?

My intention was to use the same mechanism that painkillers are currently using. I cited the dermatik effect because it actually has the sleepiness mod values in its definition, but painkillers would be the drug analogy.

@Maleclypse
Copy link
Member

We are wanting to migrate away from drug effects to drug vitamins. So that would be the system of preference to use.

@TRScheel
Copy link
Contributor Author

We are wanting to migrate away from drug effects to drug vitamins. So that would be the system of preference to use.

Can you point me to some examples of this that I can use for reference? You don't need to fish out the actual code for it, I can look it up myself. I would just appreciate knowing what is considered a 'good example' for the drugs moving forward.

@IdleSol
Copy link

IdleSol commented Dec 31, 2024

I've been told I'm not good at being concise. So if you can get through the wall of text, maybe this will help you.
#77022

And I'm not sure what the developers consider to be a good example. Maybe this: #70239

@TRScheel
Copy link
Contributor Author

TRScheel commented Jan 3, 2025

I've been told I'm not good at being concise. So if you can get through the wall of text, maybe this will help you. #77022

And I'm not sure what the developers consider to be a good example. Maybe this: #70239

Thanks, I will review it.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 18, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

3 participants