Change to Code fix for #71971 Water purification tablets only purify up to 4 water each #76326

[Severhead]

Is your feature request related to a problem? Please describe.

Water purification tablets are designed for one qt army canteens which hold 6 charges of water.

Solution you would like.

Instead of purifying a bottle of water (4 charges) it should clean a canteen (6 charges)

Describe alternatives you have considered.

Increasing the amount cleaned to a 2 qt canteen with 12 charges of water

Additional context

Military grade tablets clean 1.5 liters or less in 30 minutes of time.
National Stock Number (NSN) 6850-01-618-1533, or NIIN 016181533, (water purification tablet,iodine)

(FEAT) IODINE; 8 MG TABLET; BOTTLE OF 50 (SUFFICIENT FOR 25 WATER PURIFICATION TREATMENTS); SHELF LIFE IS 4 YEARS IF SEAL IS NOT BROKEN; SHELF LIFE REDUCED TO 1 YEAR WHEN SEAL IS BROKEN; KEEP AWAY FROM WATER OR HUMIDITY; EPA REGISTERED

[ZeroInternalReflection]

#71971 was written with specific consumer tablets in mind (see notes I left in the json):

Cataclysm-DDA/data/json/items/chemicals_and_resources.json

Lines 1185 to 1189 in 5e06aad

	"//": "Modeled after camping-scale aquatabs (https://cdn.shopify.com/s/files/1/0371/7506/6755/files/2020-49mg_insert.pdf?v=1592588294). Usage procedure is: clarify and decant water, add tablets, mix for 10 minutes, wait for 30.",
	"//2": "The recommended usage is 1 tablet per L, going to 2 tablets if cloudy/stained/cold",
	"//3": "The same company manufactures larger tablets for larger volumes, but the amount of active ingredient per litre of water is roughly equivalent and the procedure is similar",
	"//4": "The infrastructure does not currently exist for modelling whether water is cloudy.",
	"//5": "Based on this: usage is modeled in-game as: 1. Spend 5m/1L with significant batch savings to decant, 2. Add tablets 3. Assume mixing can be arranged, 4. wait 40 minutes for clean water.",

Given that many (but not all) of the tablet sources are military or military-adjacent, it might make sense to:

1. Reconfigure to model the "military style" tablets rather than "camping style", or
2. Have different "brands"/sizes of tablets (this would probably require separate water purification recipes, which might be annoying), or
3. Bump up purification tablet spawns from military-related sources by 50-100% to handwave the different types

If someone wanted to change the ratio, then I think it's possible to do it locally within the json by changing the activation ratio here:

Cataclysm-DDA/data/json/items/chemicals_and_resources.json

Line 1196 in 5e06aad

"variables": { "water_per_tablet": "4" }

And changing the recipe here (Wait, shouldn't that be water_murky, 4?):

Cataclysm-DDA/data/json/recipes/recipe_food.json

Line 101 in 5e06aad

"components": [ [ [ "water_murky", 1 ] ], [ [ "pur_tablets", 1 ] ] ]

The "making sure it purifies the water on activation" tests are unfortunately fairly strongly linked to the 1:4 ratio, so changing it in-repo would require c++ tinkering here:

Cataclysm-DDA/tests/iuse_test.cpp

Line 762 in 5e06aad

TEST_CASE( "water_purification_tablet_activation", "[iuse][pur_tablets]" )

The different inventory scenarios being tested should be fairly self-explanatory, and it would just be a matter of updating the numbers to suit.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.