Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair of heavy survivor gloves and boots. 100% steel covering #73147

Closed
IdleSol opened this issue Apr 20, 2024 · 6 comments · Fixed by #74147
Closed

Pair of heavy survivor gloves and boots. 100% steel covering #73147

IdleSol opened this issue Apr 20, 2024 · 6 comments · Fixed by #74147
Labels
Good First Issue This is a good first issue for a new contributor (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@IdleSol
Copy link

IdleSol commented Apr 20, 2024

Describe the bug

pair of heavy survivor boots https://cdda-guide.nornagon.net/item/boots_hsurvivor
pair of heavy survivor gloves https://cdda-guide.nornagon.net/item/gloves_hsurvivor

Completely covered in steel. That's not possible.

Attach save file

n/a

Steps to reproduce

n/a

Expected behavior

I believe that it is necessary to reduce the steel coating to 50..60% for gloves and 80-90% for boots. But these values come from my perception, not from calculations.

Screenshots

No response

Versions and configuration

cdda-windows-tiles-x64-2024-04-19-0435

Additional context

@fairyarmadillo You said you were planning to change the survivor outfit. Are you still planning that?

@IdleSol IdleSol added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Apr 20, 2024
@worm-girl
Copy link
Contributor

worm-girl commented Apr 20, 2024

Nope.

@Kantonine
Copy link
Contributor

Nope.

What made you decide against it?

@GuardianDll GuardianDll added Good First Issue This is a good first issue for a new contributor (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels May 8, 2024
@HarryWang05
Copy link
Contributor

Wouldn't this also be a problem for the heavy survivor suit?

@Kantonine
Copy link
Contributor

Kantonine commented May 27, 2024

Wouldn't this also be a problem for the heavy survivor suit?

The heavy survivor suit isn't craftable anymore, and really should be removed, so its not important, the heavy survivor boots are supposed to be removed too, alongside the firesuit and wetsuit survivor boots, they deliberately havent recieved a update when #65741 was merged. the steel-plated kevlar jumpsuit (which is pretty incongruent with the heavy suvivor mask due to the difference in steel grade) doesn't have the issue regarding articulation, as the steel coverage is 90% for either layer (Which also reminds me, if fairyarmadillo isn't interested in reworking the remaing survivor items, that i might have to do it myself)

@IdleSol
Copy link
Author

IdleSol commented May 28, 2024

@Kantonine Provided you take on the task of fixing the survivor equipment. Will you do a PR right away or through discussion?

My personal opinion is that because of the partial fixes, this equipment has strayed from the original concept. And different parts in different directions.

@Kantonine
Copy link
Contributor

Will you do a PR right away or through discussion?

My personal opinion is that because of the partial fixes, this equipment has strayed from the original concept. And different parts in different directions.

I'd rather have a thorough discussion about what should be done about all the survivor gear, rather than push a pr through straight away, so that we have something fully fleshed out for implementation, instead of a myriad of bandaid fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a good first issue for a new contributor (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants