Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Innawoods stream mutable to the main game #69503

Closed
NetSysFire opened this issue Nov 18, 2023 · 2 comments · Fixed by #71008
Closed

Port Innawoods stream mutable to the main game #69503

NetSysFire opened this issue Nov 18, 2023 · 2 comments · Fixed by #71008
Labels
Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Innawood 🌲 Anything to do with Innawood mod <Suggestion / Discussion> Talk it out before implementing

Comments

@NetSysFire
Copy link
Member

Is your feature request related to a problem? Please describe.

#67065 is pretty amazing and we should have this in the main game, too.

Solution you would like.

Port it. It may have minor balance implications because it makes infinite water more common again but it also adds realism.

Describe alternatives you have considered.

No response

Additional context

No response

@NetSysFire NetSysFire added <Suggestion / Discussion> Talk it out before implementing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Innawood 🌲 Anything to do with Innawood mod labels Nov 18, 2023
@Light-Wave
Copy link
Contributor

If you want to work on this, that's sounds great by me. There might be some issues left to deal with. For example, I'm not sure how streams will deal with roads. But having it in mainline would mean we get more eyes on it, and more developers involved in making it work properly.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Dec 22, 2023
@NetSysFire NetSysFire added Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! and removed stale Closed for lack of activity, but still valid. labels Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Innawood 🌲 Anything to do with Innawood mod <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants