Grab messages may be inaccurate and subject is blank

[NetSysFire]

Describe the bug

Attach save file

Backrooms-trimmed.tar.gz

Steps to reproduce

1. Bash the fat zombie with your fists.
2. The entire chain of messages is weird overall.

Edit: I can reliably reproduce this with the same save and same fat zombie, it is not a single grab that is wonky.

Expected behavior

Right arm was grabbed. Right arm got broken free from the grab.

CC @Venera3 as I know they have been working on grabs.

Screenshots

No response

Versions and configuration

• OS: Linux
  • OS Version: LSB Version: n/a; Distributor ID: Arch; Description: Arch Linux; Release: rolling; Codename: n/a;
• Game Version: 5cca213 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth],
  The Backrooms [backrooms]
  ]

Additional context

No response

[Karol1223]

If I could confirm I would, because I ran into this multiple times casually while playing as well. So uh yeah, when people who can confirm see this feel free to take my word for it

[SurFlurer]

/confirm

[Venera3]

That's a bit of a concern. I'm away for a few weeks but I'll check it out afterwards.
ETA: the grab->bp assignment was reworked in #66732, so watch me kick it forward to @bombasticSlacks ;)

[bombasticSlacks]

I'll put this on the list, but I too am away for a few weeks (on and off).

[Procyonae]

This doesn't seem specific to grabs I just had it after running into some spider while debug testing

[NetSysFire]

@Procyonae Are these weird messages considered expected or are they broken and I should open a seperate issue for this?

[AzyWng]

I don't have any screenshots or other proof, but I can say that in my own experience, the "in the X but do no damage" seems to show up whenever one, well
Attacks an enemy and hits but doesn't damage them.

[Procyonae]

@Procyonae Are these weird messages considered expected or are they broken and I should open a seperate issue for this?

I mean they appear to be the same issue or at least very related so I wouldn't open a second issue. Getting a message about not dealing damage is normal but the subject being blank obviously isn't expected

[inogenous]

Debugging a case of the following:

The fat zombie grabs your right arm!
You break the fat zombie's grab on your right leg!

(different bodyparts)

The following happens:

1. A grab effect is added for "right leg" bodypart at https://github.com/CleverRaven/Cataclysm-DDA/blob/cdda-experimental-2023-09-22-1817/src/mattack_actors.cpp#L574
2. Another grab effect is added for "right arm" bodypart at https://github.com/CleverRaven/Cataclysm-DDA/blob/cdda-experimental-2023-09-22-1817/src/mattack_actors.cpp#L865
3. In Creature::add_effect, there is a check for whether the player already has a grab effect, making step 2 have no effect. Instead, the grab from step 1 is still present.
4. The bodypart in step 2 ("right arm") is what is displayed as a message, a few lines before the effect is added: https://github.com/CleverRaven/Cataclysm-DDA/blob/cdda-experimental-2023-09-22-1817/src/mattack_actors.cpp#L858
5. When breaking free, the bodypart from step 1 ("right leg") is used for the displayed message.

Unsure if this means that the zombie gets two opportunities for grabs, both in step 1 and step 2.