Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression-cannot extinguish fire lit in an oven by examining the object, another menu pops-up #58006

Closed
matt32106 opened this issue May 29, 2022 · 4 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@matt32106
Copy link
Contributor

matt32106 commented May 29, 2022

Describe the bug

cannot extinguish fire lit in an oven by examining the object, another menu pops-up

Steps to reproduce

Light a fire in an oven
Try to extinghuish it by examining the oven, you cannot

Expected behavior

IIRC it used to be possible to examine an oven and if there was a fire inside, you could extinguish it. Please bring back this capability.

Screenshots

No response

Versions and configuration

build type: linux-tiles-x64
build number: 2022-05-28-1015
commit sha: 9129922
commit url: 9129922

Additional context

It is even more a problem when you setup a firewood source, if you cannot extinguish the fire it will burn all your stockpile

@matt32106 matt32106 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label May 29, 2022
@GuardianDll
Copy link
Member

How do you imagine this? The oven has some extinguisher inside, that extinguish flame by pressing the button?
That was removed with a reason

@ZeroInternalReflection
Copy link
Contributor

ZeroInternalReflection commented May 30, 2022

For the record, tested in "cdda-linux-tiles-sounds-x64-2022-05-29-0616":
Disconnected oven (e.g. as generated in a random house)

  • Can start a fire 'in the oven'
  • Treated as a 'nearby fire' for crafting
  • No option to extinguish a fire when examining
  • Fire can be put out by dropping water on it/activating a fire extinguisher
  • A firewood source next to the oven will automatically be used to maintain the fire

Oven appliance (after 'connecting to grid')

  • Cannot start a fire on this tile

Given that an oven worked as a fireplace in previous versions (it still kind of works now, right up until you want to extinguish it) and we still abstract away putting out a fire in a fire pit, I think the UX here still needs work. Options include:

  1. When examining any tile that's on fire, have the first check be a "This is on fire! Do you want to extinguish with water/sand/fire extinguisher" menu
  2. Prevent the player from starting a fire on a 'disconnected oven'. While, as I understand it, you can keep a wood fire going inside of a typical oven in real life, I'm betting that it wouldn't do what you need for many of the 'nearby fire' crafting recipes
  3. Prevent non-approved fire locations from pulling from firewood sources

@Qrox
Copy link
Contributor

Qrox commented May 30, 2022

Caused by #56807.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Feb 4, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

4 participants