Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous usage of salt_seasoning ingredient list in certain recipes #53211

Closed
FoolsGold45 opened this issue Dec 4, 2021 · 4 comments · Fixed by #53248
Closed

Erroneous usage of salt_seasoning ingredient list in certain recipes #53211

FoolsGold45 opened this issue Dec 4, 2021 · 4 comments · Fixed by #53248
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON

Comments

@FoolsGold45
Copy link
Contributor

FoolsGold45 commented Dec 4, 2021

Describe the bug

Deluxe fried egg recipes are pulling from an ingredient list intended for curing meat, for use as a seasoning. The most obvious issue is that this list includes black gunpowder.

Steps to reproduce

  1. Make a character with all recipes unlocked
  2. Check crafting ingredients for deluxe fried eggs, deluxe fried egg sandwich, and wheat-free deluxe fried egg sandwich

Expected behavior

To not be able to salt my eggs with gunpowder, medical saline solution, etc

Screenshots

No response

Versions and configuration

Current experimental

Additional context

No response

@FoolsGold45
Copy link
Contributor Author

FoolsGold45 commented Dec 4, 2021

#45611 I guess this was done on purpose? Looks like this pr was intended for purely meat Preservation recipes though, the current utilization of this ingredient list for fresh foods such as eggs and hot dogs seems unintended.

It appears to be drawing from the seasoning_salt ingredient list when mild_seasoning would be more appropriate

@FoolsGold45 FoolsGold45 reopened this Dec 4, 2021
@Alex-Folts
Copy link
Contributor

Alex-Folts commented Dec 4, 2021

I saw recipe also use saltpeter, which is potassium nitrate, which is one of components in clasic recipe for black powder. I think thats why.

@Owlfren
Copy link
Contributor

Owlfren commented Dec 4, 2021

Gunpowder has been used in drinks and as a seasoning IRL so I'm guessing that's where it is drawn from. That said I'm not sure how common that is these days (other than the whiskey shots).

@FoolsGold45
Copy link
Contributor Author

Regardless, the recipe list that includes black gunpowder is clearly intended for meat preservation. The fried egg recipes should not be utilizing it.

@FoolsGold45 FoolsGold45 changed the title Black Gunpowder is an option for food seasoning. Erroneous usage of salt_seasoning ingredient list in certain recipes Dec 4, 2021
@BrettDong BrettDong added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Dec 5, 2021
@Maleclypse Maleclypse added [JSON] Changes (can be) made in JSON Good First Issue This is a good first issue for a new contributor labels Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants