Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bread made with lard #46279

Closed
Svankensen opened this issue Dec 23, 2020 · 11 comments
Closed

Bread made with lard #46279

Svankensen opened this issue Dec 23, 2020 · 11 comments
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON

Comments

@Svankensen
Copy link

Is your feature request related to a problem? Please describe.

At least in my country, about half the bread that is sold in cities includes lard as an ingredient. It can also be made with vegetable oil. In rural, isolated areas, people buy veritable buckets of lard (rectangular, 15ish lt container) to make bread for months. It would also give us more uses for animal fat.

Describe the solution you'd like

A recipe that includes lard/tallow/vegetable oil for more calorie dense bread. IRL the lard/flour proportion is 1/10 by weight. According to wikipedia, the bread is similar to scones, whatever those are. Bread is savory, not sweet tho.

Describe alternatives you've considered

Not doing it.

Additional context

https://en.wikipedia.org/wiki/Hallulla

@anothersimulacrum anothersimulacrum added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor Items: Food / Vitamins Comestibles and drinks labels Dec 23, 2020
@stale
Copy link

stale bot commented Jan 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jan 23, 2021
@anothersimulacrum anothersimulacrum removed the stale Closed for lack of activity, but still valid. label Jan 23, 2021
@Maleclypse
Copy link
Member

Maleclypse commented May 1, 2021

Shouldn't the bread in #46282 have lard as an ingredient? Per the item description "lard or animal oil". Only animal oil is in the recipe.

@actual-nh
Copy link
Contributor

Ping: @ToxiClay?

@ToxiClay
Copy link
Contributor

ToxiClay commented May 1, 2021

Ping: @ToxiClay?

I....can't find it in the codebase anymore? What?

@Maleclypse
Copy link
Member

Ping: @ToxiClay?

I....can't find it in the codebase anymore? What?

It’s in the 0.F -dev branch. I think.

@ToxiClay
Copy link
Contributor

ToxiClay commented May 1, 2021

Ping: @ToxiClay?

I....can't find it in the codebase anymore? What?

It’s in the 0.F -dev branch. I think.

Oh, did they switch where the master branch is pointing? That's not confusing. 🙃 Lemme check out the 0.F dev branch I guess, lmao.

@ToxiClay
Copy link
Contributor

ToxiClay commented May 1, 2021

Success! Now, am I PRing this against 0.F-dev, because that's where it lives right now?

{
    "type": "recipe",
    "activity_level": "LIGHT_EXERCISE",
    "result": "hallula",
    "category": "CC_FOOD",
    "subcategory": "CSC_FOOD_BREAD",
    "skill_used": "cooking",
    "difficulty": 3,
    "charges": 8,
    "time": "30 m",
    "batch_time_factors": [ 50, 5 ],
    "book_learn": [ [ "family_cookbook", 1 ], [ "baking_book", 2 ], [ "cookbook", 2 ] ],
    "qualities": [ { "id": "COOK", "level": 3 } ],
    "tools": [ [ [ "surface_heat", 8, "LIST" ] ] ],
    "components": [
      [ [ "flour", 3 ] ],
      [ [ "yeast", 2 ] ],
      [ [ "sugar", 1 ] ],
      [ [ "salt", 1 ] ],
      [ [ "water", 1 ] ],
      [ [ "any_butter_or_oil", 2, "LIST" ], [ "edible_lard", 1, "LIST" ] ]
    ],
    "//": "I'm not sure whether this should also be rewritten to use a portion of charges, or scaled up so that the smallest component in the recipe becomes a single charge.",
    "//2": "Since milk is only used sparingly in the creation of hallula, to give it a glazed appearance, Cataclysm practicality suggests omitting it."
  }

image

@ToxiClay
Copy link
Contributor

ToxiClay commented May 1, 2021

#48728

@actual-nh
Copy link
Contributor

It’s in the 0.F -dev branch. I think.

Oh, did they switch where the master branch is pointing? That's not confusing. 🙃 Lemme check out the 0.F dev branch I guess, lmao.

Not quite. The master branch still has bugfixes and a few updates (e.g., tilesets) happening, but is being prepped to be 0.F. The 0.F-dev branch (which has been intermittently rebased vs the master branch) will be merged with it after 0.F is out.

@stale
Copy link

stale bot commented Jun 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jun 3, 2021
@pjf
Copy link
Contributor

pjf commented Jul 5, 2021

Now that #48728 has been merged, can this issue be closed? 🍞

@stale stale bot removed the stale Closed for lack of activity, but still valid. label Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Good First Issue This is a good first issue for a new contributor Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

No branches or pull requests

6 participants